Partial fills #26
Partial fills #26
Conversation
worked on test cases
This reverts commit ae04d03.
worked on test cases create pool,join pool(swap) test cases.
working on primary Pool test case
added and upgrade
| @@ -12,21 +13,22 @@ import { getSigner, impersonate, impersonateWhale } from '../../../src/signers'; | |||
| import { MAX_UINT256 } from '@balancer-labs/v2-helpers/src/constants'; | |||
| import { SignerWithAddress } from '@nomiclabs/hardhat-ethers/dist/src/signer-with-address'; | |||
|
|
|||
| describeForkTest('PrimaryPoolFactory', 'goerli', 8586768, function () { | |||
| describeForkTest('PrimaryPoolFactory', 'mainnet', 8586768, function () { | |||
There was a problem hiding this comment.
@vinaykumar0103 we do not have a deployment of the primary pool on mainnet. It is on goerli, can you check with goerli ? The VCUSD and other addresses are also for goerli only.
| await usdc.connect(whale).approve(vault.address, MAX_UINT256); | ||
| await usdc.connect(whale).approve(vault.address, MAX_UINT256); |
There was a problem hiding this comment.
@vinaykumar0103 should this approval be for VCUSD ? We already have given approval for USDC in the above line.
| await vault | ||
| .connect(owner) | ||
| .swap( | ||
| { kind: SwapKind.GivenIn, poolId, assetIn: usdc, assetOut: usdc, amount, userData: '0x' }, |
There was a problem hiding this comment.
@vinaykumar0103 swap assetIn and assetOut are the same ? They should be different. And 'amount' of assets swapped in should be there in balance.
|
|
||
| const provider = new ethers.providers.JsonRpcProvider(); | ||
| const ownerBalance = await provider.getBalance(ownerAddress); | ||
| console.log("Owner's ETH balance: ", ownerBalance.toString()); |
There was a problem hiding this comment.
@vinaykumar0103 why are you checking ETH balance ? You should check if swapped in asset balance is available. assetIn and assetOut (ie, USDC and VCUSD) are ERC20 tokens.
update VCUSD address and update approve issues
change mainnet to goerli,and resolve approve issues and replace VCUSD whale new address
Description
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution