Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Specify a custom node binary with PKG_NODE_PATH #43

Closed
wants to merge 1 commit into from

Conversation

shawwn
Copy link

@shawwn shawwn commented Jun 21, 2018

(This is useful for packaging a debug build of node.)

@jpx83
Copy link

jpx83 commented Aug 28, 2018

@igorklopov Can you have a look regarding this new feature? It will be very useful! Thank you.

@rauchg
Copy link
Member

rauchg commented Jan 2, 2019

Can we document the flag in README?

@rauchg rauchg added the WIP label Jan 2, 2019
@leerob
Copy link
Member

leerob commented May 24, 2021

Closing as inactive, feel free to open a new PR and we can get this through 🙏

@leerob leerob closed this May 24, 2021
@OmgImAlexis
Copy link

@leerob with this only being a 2 line change is there any reason not to allow this?

@leerob
Copy link
Member

leerob commented May 25, 2021

@OmgImAlexis there hadn't been any activity in years here. Is there an open issue related to this - or how did you find this? Happy to reconsider if multiple people are interested.

@OmgImAlexis
Copy link

@OmgImAlexis there hadn't been any activity in years here. Is there an open issue related to this - or how did you find this? Happy to reconsider if multiple people are interested.

I've been subscribed for about a year. There's no activity as you'll find most long terms GitHub users won't comment as they're met with the "don't +1 this" instead we just subscribe. I assumed the PR was good to go and just hadn't been merged.

My issue was wanting to pass in a custom version for development as someone else stated.

@leerob
Copy link
Member

leerob commented May 25, 2021

@OmgImAlexis Ahh, got it! In that case, happen to re-open.

@leerob leerob reopened this May 25, 2021
@leerob
Copy link
Member

leerob commented May 25, 2021

For more clarity, this needs:

  • Documentation added to the README explaining how to use the flag
  • Merge conflicts resolved

And then I will +1 and merge/release!

@robertsLando
Copy link
Contributor

Docs should be added on pkg readme, in this section: https://github.com/vercel/pkg#environment

@baparham
Copy link
Contributor

is anyone still interested in this?

@robertsLando
Copy link
Contributor

For anyone that is enterested in this project, giving that I don't receive any feedback from Vercel anymore, I created my own forks of both pkg and pkg-fetch:

yao-pkg/pkg-fetch
yao-pkg/pkg

If someone is interested in helping me create a PR or move your active PR to those repositories.

Thanks 🙏🏼

@robertsLando
Copy link
Contributor

This has been added by: yao-pkg#7

@leerob leerob closed this Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants