Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Commit

Permalink
patches: add patch for node 19.6 (#274)
Browse files Browse the repository at this point in the history
  • Loading branch information
phated authored Feb 14, 2023
1 parent 34522ec commit 7b23050
Show file tree
Hide file tree
Showing 13 changed files with 569 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/arm64-alpine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18]
target-node: [14, 16, 18, 19]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/arm64-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18]
target-node: [14, 16, 18, 19]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/arm64-linuxstatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18]
target-node: [14, 16, 18, 19]
target-arch: [arm64]
include:
- target-arch: arm64
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/arm64-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18]
target-node: [14, 16, 18, 19]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-alpine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18]
target-node: [14, 16, 18, 19]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18]
target-node: [14, 16, 18, 19]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-linuxstatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18]
target-node: [14, 16, 18, 19]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18]
target-node: [14, 16, 18, 19]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18]
target-node: [14, 16, 18, 19]
target-arch: [x64, arm64]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false # prevent test to stop if one fails
matrix:
node-version: [10, 12, 14, 16, 18]
node-version: [10, 12, 14, 16, 18, 19]
os: [ubuntu-latest] # Skip macos-latest, windows-latest for now

runs-on: ${{ matrix.os }}
Expand Down
14 changes: 10 additions & 4 deletions lib/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,11 @@ function getConfigureArgs(major: number, targetPlatform: string): string[] {
// production binaries do NOT take NODE_OPTIONS from end-users
args.push('--without-node-options');

// DTrace
args.push('--without-dtrace');
// The dtrace and etw support was removed in https://github.com/nodejs/node/commit/aa3a572e6bee116cde69508dc29478b40f40551a
if (major <= 18) {
// DTrace
args.push('--without-dtrace');
}

// bundled npm package manager
args.push('--without-npm');
Expand Down Expand Up @@ -176,8 +179,11 @@ async function compileOnWindows(
const major = getMajor(nodeVersion);
const config_flags = getConfigureArgs(major, targetPlatform);

// Event Tracing for Windows
args.push('noetw');
// The dtrace and etw support was removed in https://github.com/nodejs/node/commit/aa3a572e6bee116cde69508dc29478b40f40551a
if (major <= 18) {
// Event Tracing for Windows
args.push('noetw');
}

// Performance counters on Windows
if (major <= 10) {
Expand Down
Loading

0 comments on commit 7b23050

Please sign in to comment.