Add webpack loader support for '.css.ts' imports #48222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuttonJack
requested review from
timneutkens,
ijjk,
shuding,
a team and
huozhi
as code owners
added 7 commits
April 11, 2023 11:44
|
Hey @SuttonJack I just took a deeper look, and I'll open a more general fix for this shortly with tests! Thanks again for helping looking into this. |
|
Closing in favor of #48306 |
shuding
added a commit
that referenced
this pull request
Apr 12, 2023
Closes #48222. This PR introduces a new utility function that checks the resource path, module type, and loaders to replace the existing CSS regex in the Flight loaders and plugins. The new function is more robust and can be extended to correctly support other libraries such as `vanilla-extract`. cc @SuttonJack and @SukkaW (this could be related to the other issue we've discussed too).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds support for
.css.tsimports in RSC files (app directory) forvanilla-extractcompatibilityPartially resolves the
vanilla-extractissue hereHow?
regexCSS