Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: deprecate custom config from being passed to next/build (2/6) #45455

Merged
merged 15 commits into from
Feb 1, 2023
Merged

misc: deprecate custom config from being passed to next/build (2/6) #45455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e853514
refactor webpack build out of build/index
feedthejim Jan 27, 2023
f124f1d
Merge branch 'canary' into refactor-build
kodiakhq[bot] Jan 27, 2023
010f379
Merge branch 'canary' into refactor-build
kodiakhq[bot] Jan 27, 2023
c36d403
remove debugger
feedthejim Jan 27, 2023
25cb709
lint
feedthejim Jan 27, 2023
0a72d0f
Merge branch 'canary' into refactor-build
feedthejim Jan 31, 2023
36afd0a
fix merge artifact
feedthejim Jan 31, 2023
a067380
fix types
feedthejim Jan 31, 2023
cd5783a
fix types
feedthejim Feb 1, 2023
ee78594
fix types
feedthejim Feb 1, 2023
7b2ec89
Merge branch 'canary' into refactor-build
feedthejim Feb 1, 2023
c17cbd4
fix types (for real)
feedthejim Feb 1, 2023
078fd21
misc: deprecate custom config from being passed to next/build
feedthejim Jan 30, 2023
c8afffd
Merge branch 'canary' into 01-30-misc_deprecate_custom_config_from_be…
kodiakhq[bot] Feb 1, 2023
6baadce
Merge branch 'canary' into 01-30-misc_deprecate_custom_config_from_be…
kodiakhq[bot] Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/next/src/build/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,6 @@ function pageToRoute(page: string) {

export default async function build(
dir: string,
conf = null,
reactProductionProfiling = false,
debugOutput = false,
runLint = true,
Expand All @@ -271,7 +270,7 @@ export default async function build(

const config: NextConfigComplete = await nextBuildSpan
.traceChild('load-next-config')
.traceAsyncFn(() => loadConfig(PHASE_PRODUCTION_BUILD, dir, conf))
.traceAsyncFn(() => loadConfig(PHASE_PRODUCTION_BUILD, dir))

const distDir = path.join(dir, config.distDir)
setGlobal('phase', PHASE_PRODUCTION_BUILD)
Expand Down
1 change: 0 additions & 1 deletion packages/next/src/cli/next-build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ const nextBuild: CliCommand = (argv) => {

return build(
dir,
null,
args['--profile'],
args['--debug'] || process.env.NEXT_DEBUG_BUILD,
!args['--no-lint'],
Expand Down