FEAT: Slimmer Docker image #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using `alpine:3` for final image for smaller image size; - REMOVED `JAVA_OPTS` argument as args don't play nicely with `CMD` in Dockerfile; - using Alpine Linux explicity for `app-builder` stage; - using preferred `ENTRYPOINT` and `CMD` form for `dumb-init`; - removed version from execution and use a vanilla name in copy instead; and - use ADD to directly install `dumb-init` in the final image.
MaximPlusov
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alpine:3for final image for smaller image size;JAVA_OPTSargument as args don't play nicely withCMDin Dockerfile;app-builderstage;ENTRYPOINTandCMDform fordumb-init;dumb-initin the final image.For reference, these changes substantially slim down the docker image again. See the difference between the
alpinetag andlatestbelow.