Fix issue with callback cache controller hashing Closures (joomla#14057)

* Fix issue with callback cache controller hashing Closures * Wrap in array
venomDeved · Feb 14, 2017 · 73f9aa1 · 73f9aa1
1 parent 9bc0f19
commit 73f9aa1
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/libraries/joomla/cache/controller/callback.php b/libraries/joomla/cache/controller/callback.php
@@ -212,6 +212,14 @@ protected function _makeId($callback, $args)
 			$callback[0] = $vars;
 		}
 
+		// A Closure can't be serialized, so to generate the ID we'll need to get its hash
+		if (is_a($callback, 'closure'))
+		{
+			$hash = spl_object_hash($callback);
+
+			return md5($hash . serialize(array($args)));
+		}
+
 		return md5(serialize(array($callback, $args)));
 	}
 }