Merge pull request #26 from vend/update-is-finite

Update isFinite Type
vend · Jan 29, 2020 · a41b9ca · a41b9ca
2 parents ef15190 + ceeebae
commit a41b9ca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,5 +1,3 @@
 language: node_js
 node_js:
   - "6"
-  - "5"
-  - "4"
diff --git a/index.d.ts b/index.d.ts
@@ -64,7 +64,7 @@ declare module 'vend-number' {
     static multiply(...values: Stringable[]): number
     static divide(...values: Stringable[]): number
     static sumBy<T, K extends keyof T>(collection: T[], property: K, decimalPoints: number): string
-    static isFinite(value: number | string | BigNumber): boolean
+    static isFinite(value: null | number | string | BigNumber): boolean
   }
 
   export function vn(value?: Stringable): VendNumber
@@ -74,5 +74,5 @@ declare module 'vend-number' {
   export function multiply(...values: Stringable[]): number
   export function divide(...values: Stringable[]): number
   export function sumBy<T, K extends keyof T>(collection: T[], property: K, decimalPoints: number): string
-  export function isFinite(value: number | string | BigNumber): boolean
+  export function isFinite(value: null | number | string | BigNumber): boolean
 }