Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade web vitals to v4 #318

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Upgrade web vitals to v4 #318

merged 2 commits into from
Oct 15, 2024

Conversation

phibkro
Copy link
Contributor

@phibkro phibkro commented Sep 3, 2024

Replace "ReportHandler" with (metric: MetricType) => void.
Replace "getXXX" functions with "onXXX".

Replace "ReportHandler" with (metric: MetricType) => void. Replace "getXXX" functions with "onXXX".
@phibkro phibkro self-assigned this Sep 3, 2024
Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link
Contributor

@FilipSkaug FilipSkaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FilipSkaug FilipSkaug added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 4eeb2b5 Oct 15, 2024
3 of 7 checks passed
@FilipSkaug FilipSkaug deleted the upgrade-web-vitals-to-v4 branch October 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants