Add comment to explain type cast

vega · Feb 11, 2018 · 8015021 · 8015021
1 parent 158d2a7
commit 8015021
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/components/data-pane/wildcard-field-drop-zone.tsx b/src/components/data-pane/wildcard-field-drop-zone.tsx
@@ -56,6 +56,9 @@ const customWildcardFieldTarget: DropTargetSpec<CustomWildcardFieldDropZoneProps
       return;
     }
 
+    // Casting to DraggedFieldIdentifier because of bad TS type inference
+    // It does not realize that the object contains the property `fieldDef`
+    // We do the same thing in `encoding-shelf.tsx for `encodingShelfTarget`
     const {fieldDef} = monitor.getItem() as DraggedFieldIdentifier;
     const type = fieldDef.type;
 
@@ -81,6 +84,9 @@ const customWildcardFieldTarget: DropTargetSpec<CustomWildcardFieldDropZoneProps
     });
   },
   canDrop(props, monitor) {
+    // Casting to DraggedFieldIdentifier because of bad TS type inference
+    // It does not realize that the object contains the property `fieldDef`
+    // We do the same thing in `encoding-shelf.tsx for `encodingShelfTarget`
     const {fieldDef} = monitor.getItem() as DraggedFieldIdentifier;
     return fieldDef.field !== '*';
   }