-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: adds taplo.toml
, pyproject.toml
#647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the default glob `**/uv.lock` https://github.com/astral-sh/setup-uv/tree/v4/?tab=readme-ov-file#cache-dependency-glob
Basing off the equivalent step in `mosaic` https://github.com/uwdata/mosaic/blob/797a7c379e5a50228dabf5953c5de58fe9ee00a2/.github/workflows/test.yml#L50-L53
dangotbanned
added
the
github_actions
Pull requests that update Github_actions code
label
Dec 14, 2024
domoritz
reviewed
Dec 14, 2024
domoritz
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #646
Description
This PR adds formatting of
.toml
viataplo
and formatting & linting ofpython
withruff
.The
ruff
config is based on what we use foraltair
in (https://github.com/vega/altair/blob/main/pyproject.toml)I've disabled
ruff
for essentially anything that I haven't written.If there is a desire to clean up old code, we can work on reducing the scripts listed in follow-up PRs:
vega-datasets/pyproject.toml
Lines 18 to 30 in c48731b
Note
The
build_datapackage.py
exclusion will be dropped after this is merged.I fixed these already in (fbd1be5)
Tasks
uvx taplo fmt
(9a0a22d)uvx ruff check; uvx ruff format
(3706ebb)