Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adds taplo.toml, pyproject.toml #647

Merged
merged 11 commits into from
Dec 15, 2024
Merged

ci: adds taplo.toml, pyproject.toml #647

merged 11 commits into from
Dec 15, 2024

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Dec 14, 2024

Will close #646

Description

This PR adds formatting of .toml via taplo and formatting & linting of python with ruff.

The ruff config is based on what we use for altair in (https://github.com/vega/altair/blob/main/pyproject.toml)

I've disabled ruff for essentially anything that I haven't written.
If there is a desire to clean up old code, we can work on reducing the scripts listed in follow-up PRs:

[tool.ruff]
extend-exclude = [
".venv",
"scripts/budget.py",
"scripts/flights.py",
"scripts/github.py",
"scripts/make-unemployment-across-industries.py",
"scripts/update_countries_json.py",
"scripts/update_gapminder.py",
"scripts/weather.py",
# TEMPORARY
"scripts/build_datapackage.py",
]

Note

The build_datapackage.py exclusion will be dropped after this is merged.
I fixed these already in (fbd1be5)

Tasks

  • Add config files
  • Adapt actions workflow (3bb974a)

@dangotbanned dangotbanned added the github_actions Pull requests that update Github_actions code label Dec 14, 2024
@dangotbanned dangotbanned marked this pull request as ready for review December 14, 2024 14:16
@dangotbanned
Copy link
Member Author

@domoritz if you don't have any objections, I'd like to merge this before #643

Then I can make sure that has any ruff/taplo fixes applied before that hits main

pyproject.toml Outdated Show resolved Hide resolved
@dangotbanned dangotbanned marked this pull request as draft December 14, 2024 15:39
@dangotbanned dangotbanned marked this pull request as ready for review December 14, 2024 19:22
.github/workflows/test.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@dangotbanned dangotbanned merged commit 18a4670 into main Dec 15, 2024
2 checks passed
@dangotbanned dangotbanned deleted the ci-taplo-pyproject branch December 15, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure and run taplo in CI for formatting .toml
2 participants