-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add source for budget.json and validation script #581
Conversation
Partially addresses #15
Rather than validating, should the script just generate the file? We can always check that the diff is empty in git. It would be more similar to the other scripts. We could also run the script as part of the workflows if we want to have tests. |
What changed about the dataset? I'm asking since it affects what version bump this implies. |
…iginal dataset; add source information * dataset generated from script is identical to existing budget.json
The original and script-generated budget.json files are identical in content, but differ in formatting: the original file has no space after the colons separating keys and values, while the script in my prior commit generated a json with a space after each colon. In this new commit, I've updated the script to generate a JSON formatted like the original. Timeline of changes:
|
Having a space after the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo the last commit.
…at of original dataset; add source information" This reverts commit 6615d79.
Thank you |
Partially addresses #15
Changes made:
validate_budget_data.py
in the scripts directory to validate the budget data against the original source