Skip to content

Commit

Permalink
feat!: update to svelte 5, update eslint, remove storybook (#971)
Browse files Browse the repository at this point in the history
* feat: update to svelte 5, update eslint, remove storybook

storybook only causes errors left and right and I don't have energy to keep it working

* rm dep

* update embed
  • Loading branch information
domoritz authored Nov 7, 2024
1 parent feb7b0e commit f17f092
Show file tree
Hide file tree
Showing 31 changed files with 2,008 additions and 6,214 deletions.
4 changes: 0 additions & 4 deletions .eslintignore

This file was deleted.

36 changes: 0 additions & 36 deletions .eslintrc.js

This file was deleted.

3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,5 @@ jobs:
- name: Build Sample (Sveltekit)
run: yarn build:sample:sveltekit

- name: Build Storybook
run: yarn build:storybook

- name: Lint
run: yarn lint
27 changes: 0 additions & 27 deletions .github/workflows/pages.yml

This file was deleted.

6 changes: 0 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ svelte-vega/

### Development

#### Run storybook

```sh
yarn storybook
```

#### Run sample

```sh
Expand Down
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

> `svelte` + `vega`|`vega-lite`
See our [Storybook Demo](http://vega.github.io/svelte-vega/) and the [svelte-vega package](https://github.com/vega/svelte-vega/tree/main/packages/svelte-vega).
See the [svelte-vega package](https://github.com/vega/svelte-vega/tree/main/packages/svelte-vega).

## Packages

Expand All @@ -12,10 +12,6 @@ The primary Svelte component for Vega and Vega-Lite which can be used in your Sv

For documentation and installation instructions, go to [packages/svelte-vega](https://github.com/vega/svelte-vega/tree/main/packages/svelte-vega).

### Storybook

An interactive web demo of Svelte Vega and Vega-Lite components using `svelte-vega` with examples of updating data and chart variables.

### Sample Projects

Svelte and a SvelteKit example projects that use `svelte-vega`.
Expand Down
47 changes: 47 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
// @ts-check
import js from '@eslint/js';
import prettier from 'eslint-plugin-prettier/recommended';
import svelte from 'eslint-plugin-svelte';
import svelteParser from 'svelte-eslint-parser';
import ts from 'typescript-eslint';

/** @type {import('typescript-eslint').Config} */
export default ts.config(
js.configs.recommended,
...ts.configs.recommended,
...svelte.configs['flat/recommended'],
prettier,
...svelte.configs['flat/prettier'],
{
languageOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
parserOptions: {
parser: ts.parser,
extraFileExtensions: ['.svelte']
}
}
},
{
files: ['**/*.svelte', '*.svelte'],
languageOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
parser: svelteParser,
parserOptions: {
parser: ts.parser,
extraFileExtensions: ['.svelte']
}
}
},
{
rules: {
'@typescript-eslint/no-require-imports': 'warn',
'@typescript-eslint/no-unused-expressions': 'warn',
'no-undef': 'warn'
}
},
{
ignores: ['**/_gh-pages/', '**/.svelte-kit/', '**/dist/']
}
);
34 changes: 17 additions & 17 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,34 +14,34 @@
"build": "yarn workspace svelte-vega build",
"build:sample:svelte": "yarn build && yarn workspace svelte-vega-sample build",
"build:sample:sveltekit": "yarn build && yarn workspace sveltekit-vega-sample build",
"build:storybook": "yarn build && yarn workspace svelte-vega-demo demo:build",
"lint": "prettier --check . && eslint . --ext .svelte,.ts,.js",
"lint:fix": "prettier --write . && eslint . --ext .svelte,.ts,.js --fix",
"storybook": "yarn build && yarn workspace svelte-vega-demo storybook",
"lint": "prettier --check . && eslint",
"lint:fix": "prettier --write . && eslint --fix",
"sample:svelte": "yarn build && yarn workspace svelte-vega-sample dev",
"sample:sveltekit": "yarn build && yarn workspace sveltekit-vega-sample dev",
"clean": "rm -rf ./packages/svelte-vega/dist && rm -rf ./packages/storybook/_gh-pages && rm -rf && rm -rf ./packages/sample-project/public/build",
"clean": "rm -rf ./packages/svelte-vega/dist && rm -rf && rm -rf ./packages/sample-project/public/build",
"release": "yarn workspace svelte-vega semantic-release --branches main"
},
"devDependencies": {
"@babel/core": "^7.24.3",
"@babel/eslint-parser": "^7.24.7",
"@tsconfig/svelte": "^5.0.2",
"@typescript-eslint/eslint-plugin": "^7.4.0",
"@typescript-eslint/parser": "^7.15.0",
"commitizen": "^4.3.0",
"@babel/core": "^7.26.0",
"@babel/eslint-parser": "^7.25.9",
"@eslint/js": "^9.14.0",
"@tsconfig/svelte": "^5.0.4",
"@types/eslint__js": "^8.42.3",
"@typescript-eslint/eslint-plugin": "^8.13.0",
"commitizen": "^4.3.1",
"cz-conventional-changelog": "3.3.0",
"eslint": "^8.57.0",
"eslint": "^9.14.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-import": "^2.30.0",
"eslint-plugin-import": "^2.31.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-promise": "^7.1.0",
"eslint-plugin-svelte": "^2.38.0",
"eslint-plugin-svelte": "^2.46.0",
"prettier": "^3.3.3",
"prettier-plugin-svelte": "^3.2.2",
"semantic-release": "^23.0.6",
"typescript": "^5.5.4"
"prettier-plugin-svelte": "^3.2.7",
"semantic-release": "^24.2.0",
"typescript": "^5.6.3",
"typescript-eslint": "^8.13.0"
},
"engines": {
"node": ">16",
Expand Down
15 changes: 0 additions & 15 deletions packages/storybook/.storybook/main.js

This file was deleted.

3 changes: 0 additions & 3 deletions packages/storybook/.storybook/preview.js

This file was deleted.

52 changes: 0 additions & 52 deletions packages/storybook/package.json

This file was deleted.

Loading

0 comments on commit f17f092

Please sign in to comment.