refactor: distinct Olli renderer template #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #3580.
I prefer to keep the
HTML_TEMPLATE_UNIVERSALtemplate as is and introduce a distinctHTML_TEMPLATE_OLLItemplate for the olli renderer. Since the universal template is widely used across notebooks for almost every chart, I’d prefer to avoid mixing it with conditional jinja2 orJavaScript statements, especially when they can be avoided relatively easily.I deeply respect those that have to rely on this type of assistive technologies to browse the Internet, for me it is easy to get lost in controls without vison.