Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fixup pyproject.toml per newest Hatchling release #3678

Closed
wants to merge 1 commit into from

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Nov 10, 2024

There's a new release of hatchling is causing the build to fail:

https://github.com/narwhals-dev/narwhals/actions/runs/11764476318/job/32769662368?pr=1326:

Traceback (most recent call last):
  File "<string>", line 11, in <module>
  File "/home/runner/work/_temp/setup-uv-cache/builds-v0/.tmpqjAseZ/lib/python3.12/site-packages/hatchling/build.py", line 83, in build_editable
    return os.path.basename(next(builder.build(directory=wheel_directory, versions=['editable'])))
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/_temp/setup-uv-cache/builds-v0/.tmpqjAseZ/lib/python3.12/site-packages/hatchling/builders/plugin/interface.py", line 90, in build
    self.metadata.validate_fields()
  File "/home/runner/work/_temp/setup-uv-cache/builds-v0/.tmpqjAseZ/lib/python3.12/site-packages/hatchling/metadata/core.py", line 266, in validate_fields
    self.core.validate_fields()
  File "/home/runner/work/_temp/setup-uv-cache/builds-v0/.tmpqjAseZ/lib/python3.12/site-packages/hatchling/metadata/core.py", line 1363, in validate_fields
    getattr(self, attribute)
  File "/home/runner/work/_temp/setup-uv-cache/builds-v0/.tmpqjAseZ/lib/python3.12/site-packages/hatchling/metadata/core.py", line 753, in license_files
    raise TypeError(message)
TypeError: Field `project.license-files` must be an array

This fixes that, but it looks like there's also an issue with hatch run which may need patching in hatchling pypa/hatch#1793

@MarcoGorelli
Copy link
Contributor Author

hatchling have put out a new release, and this has fixed that, so this can be closed 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant