fix: Raise informative error message if a non-existent column name is passed #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
MarcoGorelli
commented
Aug 12, 2024
MarcoGorelli
force-pushed
the
missing-column-name-error-message
branch
from
d80c24a to
e343aae
Compare
Just to be extra cautious, since the original message in vega#3532 referenced `pandas` directly
dangotbanned
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Thanks for the quick fix @MarcoGorelli!
I wasn't expecting you'd object to d9e219b (#3533) but let me know if you do.
Other than that, I only had one minor typing-related suggestion
MarcoGorelli
commented
Aug 12, 2024
| data: pd.DataFrame | DataFrameLike | None = None, | ||
| data: IntoDataFrame | None = None, |
There was a problem hiding this comment.
I think this wasn't quite right to begin with, looking into it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3532