Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove again geopandas pin and disable flaky test #3422

Merged
merged 2 commits into from
May 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ dev = [
"pandas-stubs",
"types-jsonschema",
"types-setuptools",
"geopandas<=0.14.3",
"geopandas",
]
doc = [
"sphinx",
Expand Down Expand Up @@ -205,6 +205,10 @@ max-complexity = 18
markers = [
"save_engine: marks some of the tests which are using an external package to save a chart to e.g. a png file. This mark is used to run those tests selectively in the build GitHub Action.",
]
# Pytest does not need to search these folders for test functions.
# They contain examples which are being executed by the
# test_examples tests.
norecursedirs = ["tests/examples_arguments_syntax", "tests/examples_methods_syntax"]

[tool.mypy]
warn_unused_ignores = true
Expand Down
2 changes: 1 addition & 1 deletion tests/examples_arguments_syntax/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ def iter_examples_arguments_syntax():
yield {
"name": name,
"filename": os.path.join(examples_arguments_syntax_dir, filename),
"use_svg": name in SVG_EXAMPLES
"use_svg": name in SVG_EXAMPLES,
}
2 changes: 1 addition & 1 deletion tests/examples_methods_syntax/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ def iter_examples_methods_syntax():
yield {
"name": name,
"filename": os.path.join(examples_methods_syntax_dir, filename),
"use_svg": name in SVG_EXAMPLES
"use_svg": name in SVG_EXAMPLES,
}
8 changes: 7 additions & 1 deletion tests/test_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@

def iter_examples_filenames(syntax_module):
for _importer, modname, ispkg in pkgutil.iter_modules(syntax_module.__path__):
if ispkg or modname.startswith("_"):
if (
ispkg
or modname.startswith("_")
# Temporarily skip this test until https://github.com/vega/altair/issues/3418
# is fixed
or modname == "interval_selection_map_quakes"
):
continue
yield modname + ".py"

Expand Down
Loading