Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints: Simplify to improve user experiences #3307

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Type hints: Simplify to improve user experiences #3307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3b8d563
Switch to SchemaBase instead of specific Altair classes
binste Jan 4, 2024
3cf2e27
Same for docstrings
binste Jan 4, 2024
e36fa97
Simplify dictionaries in docstrings
binste Jan 4, 2024
568d12a
Fix deduplication of type hints
binste Jan 4, 2024
6dda8e1
Sort types by length to show str, float, etc. before core.SchemaBase …
binste Jan 4, 2024
41161af
Make order of type hints deterministic
binste Jan 4, 2024
a169844
Remove Union within Union due to UndefinedType
binste Jan 4, 2024
ed726ad
Remove unnecessary class name + dict from beginning of docstrings
binste Jan 4, 2024
9cd8ed1
Remove unused type ignore comment
binste Jan 4, 2024
3c8d5c8
Keep all class names in docstrings
binste Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion altair/vegalite/v5/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ def param(
name=parameter.name,
bind=bind,
value=value,
expr=expr, # type: ignore[arg-type]
expr=expr,
**kwds,
)
parameter.param_type = "variable"
Expand Down
103,078 changes: 46,212 additions & 56,866 deletions altair/vegalite/v5/schema/channels.py
View file
Open in desktop

Large diffs are not rendered by default.

55,443 changes: 23,914 additions & 31,529 deletions altair/vegalite/v5/schema/core.py
View file
Open in desktop

Large diffs are not rendered by default.

Loading