Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update save.py to use utf-8 instead of None per default #3278

Merged
merged 12 commits into from
Dec 6, 2023
+10 −3
Merged

Update save.py to use utf-8 instead of None per default #3278

Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
403ff87
Update save.py to use utf-8 instead of None per default
franzhaas Dec 2, 2023
4c3ae49
incorporated tips from jonmmease
franzhaas Dec 2, 2023
c49366b
- formated...
Dec 3, 2023
55e3162
- to trigger workflow..
Dec 3, 2023
c806b75
- to trigger workflow..
Dec 3, 2023
b8756c3
Update altair/utils/save.py
franzhaas Dec 4, 2023
42f223b
Update altair/utils/save.py
franzhaas Dec 4, 2023
0e1192a
fixed arg names..
franzhaas Dec 4, 2023
304ed59
improved formating...
franzhaas Dec 4, 2023
fff657b
more formating...
franzhaas Dec 4, 2023
a88b885
more formating
franzhaas Dec 4, 2023
8124af1
Update api.py
franzhaas Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions altair/utils/save.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def perform_save():

if format == "json":
json_spec = json.dumps(spec, **json_kwds)
write_file_or_filename(fp, json_spec, mode="w")
write_file_or_filename(fp, json_spec, mode="w", encoding="utf-8")
franzhaas marked this conversation as resolved.
Show resolved Hide resolved
elif format == "html":
if inline:
kwargs["template"] = "inline"
Expand All @@ -157,7 +157,9 @@ def perform_save():
json_kwds=json_kwds,
**kwargs,
)
write_file_or_filename(fp, mimebundle["text/html"], mode="w")
write_file_or_filename(
fp, mimebundle["text/html"], mode="w", encoding="utf-8"
franzhaas marked this conversation as resolved.
Show resolved Hide resolved
)
elif format in ["png", "svg", "pdf", "vega"]:
mimebundle = spec_to_mimebundle(
spec=spec,
Expand Down