Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix Chart and MarkDef language #3266

Merged
merged 4 commits into from
Mar 16, 2024

Conversation

ChiaLingWeng
Copy link
Contributor

This will close #2545,
where the usage should be alt.Chart(df, mark=alt.CompositeMarkDef(type='boxplot'))
this PR update definition in https://altair-viz.github.io/user_guide/generated/toplevel/altair.Chart.html,
image

but for MarkDef in https://altair-viz.github.io/user_guide/generated/core/altair.MarkDef.html

The mark type. This could a primitive mark type (one of "bar", "circle", "square", "tick", "line", "area", "point", "geoshape", "rule", and "text" ) or a composite mark type ( "boxplot", "errorband", "errorbar" ).

Seems like it's generated from vega-lite-schema and I might need some instruction on where to start

@joelostblom joelostblom force-pushed the fix_markdef_boxplot branch from 0ffcf6d to 082bc4a Compare March 16, 2024 17:35
@joelostblom joelostblom merged commit aa9c934 into vega:main Mar 16, 2024
10 checks passed
@joelostblom
Copy link
Contributor

Thank @ChiaLingWeng ! I did some minor formatting and rebased on main. I opened a follow up issue for the VL docstring in #3370. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxplot not working with MarkDef
2 participants