Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add range bar chart #3250

Merged
merged 4 commits into from
Nov 6, 2023
Merged

docs: add range bar chart #3250

merged 4 commits into from
Nov 6, 2023

Conversation

mattijn
Copy link
Contributor

@mattijn mattijn commented Nov 4, 2023

This example add an example to the bar chart category. It is a range bar chart where each bar displays information of a low and high value. In this example I used the temperature variation by month for Seattle (2012-2015).
image

Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Only two minor suggestions

tests/examples_methods_syntax/bar_chart_with_range.py Outdated Show resolved Hide resolved
tests/examples_arguments_syntax/bar_chart_with_range.py Outdated Show resolved Hide resolved
@mattijn
Copy link
Contributor Author

mattijn commented Nov 6, 2023

Thanks for the review @binste! Just to mention that this looks different in the Vega-lite editor:
image
Open the Chart in the Vega Editor

It seems this very visible change in appearance is introduced in VL 5.16.0

@mattijn mattijn merged commit ca89acd into main Nov 6, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants