New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hint utils/save.py and utils/mimebundle.py #3248

Merged

mattijn merged 4 commits into vega:main from binste:type_hint_remaining_utils

Nov 6, 2023

Contributor

binste commented Nov 4, 2023 •

edited

Loading

Adds type hints to utils/save.py and utils/mimebundle.py. After this PR and #3208, there are only a few minor steps left in #2951 🥳

binste added 3 commits

November 4, 2023 16:28


          Type hint mimebundle.py

b455b24


          Type hint save.py

2f6de4d


          Merge branch 'main' into type_hint_remaining_utils

3aace16

binste mentioned this pull request

Type hints: Summary issue #2951

Closed

14 tasks


          Fix type hint for py38

abd506e

Contributor

mattijn commented Nov 6, 2023

Thanks @binste! Looks good to be restrictive on output types. Almost there indeed!

mattijn merged commit 1243e73 into vega:main

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet