-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Vega-Lite 5.15.1 #3206
Conversation
**See also:** The `projection with encodings and fields section | ||
<https://vega.github.io/vega-lite/docs/selection.html#project>`__ in the | ||
documentation. | ||
fields : List(:class:`FieldName`) | ||
An array of field names whose values must match for a data tuple to fall within the | ||
selection. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in vega/vega-lite#9066 (comment), this is incorrect and will likely be removed in 5.16
@@ -15,6 +15,15 @@ Bug Fixes | |||
Backward-Incompatible Changes | |||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|||
Version 5.1.2 (released Oct 4, 2023) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update this date depending on the actual release
I'm supportive of doing a 5.1.2 release early next week. I haven't gone through the release process, but happy to make sure vl-convert is ready once Vega-Lite 5.16 is out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me too, thanks for offering to do the release! Feel free to ping me again in case you need a review once the new VL version is out.
tools/generate_schema_wrapper.py
Outdated
@@ -30,7 +30,7 @@ | |||
|
|||
# Map of version name to github branch name. | |||
SCHEMA_VERSION = { | |||
"vega-lite": {"v5": "v5.14.1"}, | |||
"vega-lite": {"v5": "v5.15.0"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads-up that I'm simplifying this part of the code in #3207 and will merge it soon -> You will have a merge conflict here which should be simple to resolve. You can then just set SCHEMA_VERSION = "v5.15.0"
as we no longer need the dictionary.
Go ahead! I'm a bit occupied these days. Ping me if you get stuck in the release proces. |
Hi all, I'm going to try to start being more involved with the day-to-day Altair maintenance than I have been in the last few months. Many things are still mysterious to me, but especially please ping me if there's something in particular you think I might be able to help with. |
v5.15.1 was just released, when I tried updating this PR it fails to find a URL required the generate the schema. The URL is https://vega.github.io/schema/vega-lite/v5.15.1.json which indeed seems to be missing so maybe there is just a build process that takes some time for that to come up? |
vl-convert-python 0.14.0 was just published to PyPI with Vega-Lite 5.15.1 support |
All checks are passing so marking this as ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you @joelostblom and @jonmmease
5.1.2 released! It was scary but I think everything is working. I didn't encounter any errors, and I tried installing 5.1.2 myself from pip and it seems to work as expected. Just waiting for https://github.com/conda-forge/altair-feedstock/pulls to update and then that should be it |
Thanks for doing the release @joelostblom! |
Looks good, thanks! 😃 |
@mattijn @binste @jonmmease @ChristopherDavisUCI Would you be OK if we make a 5.1.2 (this seems to small for 5.2?) early next week to update VL once vega/vega-lite#9106 is merged and to include #3191? It would be helpful for a class I'm teaching mid-next week. I can try to make the release since I'm the one who needs it, but if anyone has time to help if needed it is of course appreciated (the release instructions seem straightforward so hopefully I don't set anything on fire).
I put up this PR as a draft to make sure I am doing the correct thing when updating VL; I will flag for review when there is an actual VL 5.16 release. I bumped the version number in
tools/generate_schema_wrapper.py
and then ranpython tools/generate_schema_wrapper.py
, and thenhatch test
. Is that all?