Add missing arguments to Parameter and add type hints #3173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in #3143 that
alt.param
sets some attributes onalt.Parameter
which do not exist on that class when its initialised. That's a problem for mypy as all attributes should exist from the beginning. This PR addsempty
,param
, andparam_type
and type hints for the whole class.I tested with the Interval examples from the docs to make sure that indeed
empty=Undefined
leads toempty
not being present in the final chart dict which is the old behaviour whenempty
was not present on the parameter instance at all if it was not defined.