Specify explicit signature for __dataframe__. Remove DataFrame.versio…

…n as Pyright doesn't like that in Polars it is specified as a property which is semantically not the same as an attribute (the later can be set, properties are read-only by default)
vega · Dec 23, 2023 · 217939c · 217939c
1 parent 4eab849
commit 217939c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/altair/utils/_dfi_types.py b/altair/utils/_dfi_types.py
@@ -5,7 +5,7 @@
 #
 # These classes are only for use in type signatures
 import enum
-from typing import Any, Iterable, Optional, Tuple, Protocol
+from typing import Any, Iterable, Optional, Tuple, Protocol, Literal
 
 
 class DtypeKind(enum.IntEnum):
@@ -121,8 +121,6 @@ class DataFrame(Protocol):
     to the dataframe interchange protocol specification.
     """
 
-    version: int = 0  # version of the protocol
-
     def __dataframe__(
         self, nan_as_null: bool = False, allow_copy: bool = True
     ) -> "DataFrame":

diff --git a/altair/utils/core.py b/altair/utils/core.py
@@ -46,7 +46,9 @@
 
 
 class DataFrameLike(Protocol):
-    def __dataframe__(self, *args, **kwargs) -> DfiDataFrame:
+    def __dataframe__(
+        self, nan_as_null: bool = False, allow_copy: bool = True
+    ) -> DfiDataFrame:
         ...