Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: master commit message #741

Merged
merged 4 commits into from
May 16, 2024

Conversation

darrenvechain
Copy link
Member

@darrenvechain darrenvechain commented May 16, 2024

Description

Fix master commit message

How Has This Been Tested?

Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner May 16, 2024 09:32
@darrenvechain darrenvechain marked this pull request as draft May 16, 2024 09:32
@darrenvechain darrenvechain marked this pull request as ready for review May 16, 2024 09:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.64%. Comparing base (ef1cdb5) to head (3de9623).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   61.54%   61.64%   +0.09%     
==========================================
  Files         195      195              
  Lines       18246    18246              
==========================================
+ Hits        11229    11247      +18     
+ Misses       5925     5904      -21     
- Partials     1092     1095       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony libotony merged commit 9307346 into vechain:master May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants