-
Notifications
You must be signed in to change notification settings - Fork 1
Implement v1 of the healthcheck and create github files for open source #1
Conversation
The pull request section in the CONTRIBUTING.md file has been updated to provide clearer instructions on how to submit a pull request. The new section includes step-by-step guidelines for forking the repository, creating a new branch, making changes, and opening a pull request against the main branch of the original repository. Additionally, a tip has been added to encourage users to follow git guidelines when writing commit messages.
- Rename the file `gitleaks.yml` to `build.yml` for clarity. - Update the workflow name from "gitleaks" to "Build". - Modify the event triggers to include pull request events of types: opened, synchronize, reopened. - Add a new job named "sonarcloud" for SonarCloud analysis. - Configure SonarCloud steps to checkout code and perform the scan.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in the src folder has no comments. We need to add comments to make the code clearer. I can add them, let me know :)
Clean, readable code is usually enough to convey the intention. Failing that, comments are welcome. We also don't have any unit tests, but there's not much business logic here to be tested. Still, I had to relax the SonarCloud quality gate in order to accept a 0% unit test code coverage. Contributions in comments and tests are welcome anytime @fabiorigam, thank you in advance! |
Kudos, SonarCloud Quality Gate passed! |
No description provided.