chore(backups): convert cleanvm to typescript #8256
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephane-m-dev
changed the title
stephane-m-dev
requested review from
fbeauchamp
and removed request for
fbeauchamp
stephane-m-dev
force-pushed
the
backups-cleanvm-convert-to-ts
branch
from
d873580 to
6b88b84
Compare
fbeauchamp
reviewed
Jan 23, 2025
There was a problem hiding this comment.
I am still not convinced thah the ts compilation should be considered as necessary, but if yes, I would advise to have a /dist/ folder that contains all the build artefacts
also I think that it would be better to either really type a file ( no any ) or use jsdoc to clarify the modules status. And typing RemoteAdapter is out of reach for now
Comment on lines
+519
to
+522
| for (const vdi of Object.values(metadata.vdis ?? {})) { | ||
| const uuid = vdi.uuid | ||
| console.log({ uuid }) | ||
| metadata.isVhdDifferencing[`${uuid}.vhd`] = false |
There was a problem hiding this comment.
not related on this PR
Comment on lines
+505
to
+513
| console.log({ | ||
| /* metadata, */ vdis: metadata.vdis, | ||
| isVhdDifferencing: metadata.isVhdDifferencing, | ||
| parent: metadata.vmSnapshot.parent, | ||
| mergedSize, | ||
| fixMetadata, | ||
| fileSystemSize, | ||
| size, | ||
| }) |
There was a problem hiding this comment.
console shouldn't be in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
This is the _cleanVm.mjs built from the .mts.
This allows to see with the diff that the resulting mjs file is the same, except for the empty lines that were deleted by TSC. (not configurable)
I only executed
prettier --write *.mjsto remove the ";" at end of lines. (not configurable too)Dependencies are only partially typed at the moment.
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
Notes: