Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-6/pool): add networks view #8252

Draft
wants to merge 4 commits into
base: xo-6/pool-netowrk-view
Choose a base branch
from

Conversation

OlivierFL
Copy link
Collaborator

Description

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@OlivierFL OlivierFL self-assigned this Jan 15, 2025
@S3bastianCZ S3bastianCZ force-pushed the xo-6/pool-netowrk-view branch from e02c67f to bf042a2 Compare January 16, 2025 09:23
@OlivierFL OlivierFL force-pushed the xo-6/pool-networks-view branch 4 times, most recently from 7443898 to f49a892 Compare January 17, 2025 08:04
@S3bastianCZ S3bastianCZ force-pushed the xo-6/pool-netowrk-view branch 2 times, most recently from ccbcc9b to d7d9ed0 Compare January 20, 2025 15:09
@OlivierFL OlivierFL force-pushed the xo-6/pool-networks-view branch from f49a892 to d4066b8 Compare January 20, 2025 15:09
@S3bastianCZ S3bastianCZ force-pushed the xo-6/pool-netowrk-view branch from d7d9ed0 to 279ce96 Compare January 20, 2025 15:10
@OlivierFL OlivierFL force-pushed the xo-6/pool-networks-view branch from d4066b8 to 78092ea Compare January 20, 2025 15:18
@OlivierFL OlivierFL force-pushed the xo-6/pool-networks-view branch 2 times, most recently from a4df9a7 to 42e35d0 Compare January 20, 2025 15:38
@OlivierFL OlivierFL force-pushed the xo-6/pool-networks-view branch from 42e35d0 to 98a89c4 Compare January 20, 2025 15:40
@S3bastianCZ S3bastianCZ force-pushed the xo-6/pool-netowrk-view branch 5 times, most recently from 8ce3eba to bcfb604 Compare January 22, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants