Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message from permit more useful when you forget permissions #836

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Burgestrand
Copy link
Member

This tripped me up a bit the other day, so lets improve it.

To do

  • I have read the contributing guidelines.
  • I have added relevant tests.
  • I have adjusted relevant documentation.
  • I have made sure the individual commits are meaningful.
  • I have added relevant lines to the CHANGELOG.

PS: Thank you for contributing to Pundit ❤️

@Burgestrand Burgestrand force-pushed the kbs/add-useful-error-to-permissions-dsl branch from 6c171ed to 5aff917 Compare October 11, 2024 07:35
@Burgestrand Burgestrand force-pushed the kbs/code-janitoring branch 2 times, most recently from ba324e4 to e296e83 Compare October 11, 2024 07:57
@Burgestrand Burgestrand force-pushed the kbs/add-useful-error-to-permissions-dsl branch 2 times, most recently from 6451ee7 to 138a13e Compare October 11, 2024 08:11
@Burgestrand Burgestrand self-assigned this Oct 11, 2024
Base automatically changed from kbs/code-janitoring to main October 11, 2024 08:42
@Burgestrand Burgestrand marked this pull request as ready for review October 11, 2024 08:43
@Burgestrand Burgestrand force-pushed the kbs/add-useful-error-to-permissions-dsl branch from 138a13e to d1c3d90 Compare November 21, 2024 09:08
@Burgestrand Burgestrand merged commit a885c79 into main Nov 21, 2024
13 of 14 checks passed
@Burgestrand Burgestrand deleted the kbs/add-useful-error-to-permissions-dsl branch November 21, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant