Adjust GH actions workflow #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still want to run all tests fully, but the job as a whole should be considered failed.
Burgestrand
force-pushed
the
kbs/update-github-workflow
branch
from
2aadebc to
caed448
Compare
``` An error occurred while loading ./spec/authorization_spec.rb. Failure/Error: require "active_support/core_ext" NameError: cannot load (ext) (org.jruby.ext.psych.PsychLibrary) # ./vendor/bundle/jruby/3.1.0/gems/psych-5.1.1-java/lib/psych.rb:7:in `<main>' # ./vendor/bundle/jruby/3.1.0/gems/activesupport-7.1.1/lib/active_support/time_with_zone.rb:3:in `<main>' # ./vendor/bundle/jruby/3.1.0/gems/activesupport-7.1.1/lib/active_support/core_ext/time/zones.rb:3:in `<main>' # ./vendor/bundle/jruby/3.1.0/gems/activesupport-7.1.1/lib/active_support/core_ext/date/calculations.rb:7:in `<main>' # ./vendor/bundle/jruby/3.1.0/gems/activesupport-7.1.1/lib/active_support/core_ext/date.rb:5:in `<main>' # ./vendor/bundle/jruby/3.1.0/gems/activesupport-7.1.1/lib/active_support/core_ext.rb:5:in `block in <main>' # ./vendor/bundle/jruby/3.1.0/gems/activesupport-7.1.1/lib/active_support/core_ext.rb:3:in `<main>' # ./spec/spec_helper.rb:17:in `<main>' # ./spec/authorization_spec.rb:3:in `<main>' # ------------------ # --- Caused by: --- # Java::JavaLang::NullPointerException: # inStream parameter is null # java.base/java.util.Objects.requireNonNull(Objects.java:246) ```
Burgestrand
force-pushed
the
kbs/update-github-workflow
branch
from
caed448 to
42422b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently made a change to allow for running the workflow manually on
main, which I did in order to double-check if a certain failure was due to a PR or if it's also failing on main.I've since disabled bypassing branch protections on
main, so now there's a PR for this change.And finally, I noticed that if a required job (e.g.
jruby) fails then our tests fail fast which we don't want. We still want all tests to run, butmatrix-testshould be considered failed if any of the required ruby versions fail.