Adds tests to cover policy overrides and when authorize is called in other namespaces

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Pundit
 
+### Added
+
+- Adds tests to cover policy overrides and when authorize is called in other namespaces (#772)
+
 ## Unreleased
 
 ### Fixed

spec/authorization_spec.rb

@@ -8,6 +8,7 @@
   let(:post) { Post.new(user) }
   let(:customer_post) { Customer::Post.new(user) }
   let(:comment) { Comment.new }
+  let(:admin_comment) { Project::Admin::CommentPolicy.new(user, comment) }
   let(:article) { Article.new }
   let(:article_tag) { ArticleTag.new }
   let(:wiki) { Wiki.new }
@@ -116,6 +117,14 @@
     it "raises an error with a invalid policy constructor" do
       expect { controller.authorize(wiki, :destroy?) }.to raise_error(Pundit::InvalidConstructorError)
     end
+
+    context "when called in a controller" do
+      it "uses the Admin namespace for policy calls" do
+        policy = Project::Admin::CommentPolicy.new(user, comment)
+
+        expect(controller.authorize(admin_comment, :update?)).to eq(policy)
+      end
+    end
   end
 
   describe "#skip_authorization" do
@@ -159,6 +168,38 @@
 
       expect(controller.policy(post)).to eq new_policy
     end
+
+    it "uses the Admin namespace for policy calls" do
+      policy = Project::Admin::CommentPolicy.new(user, comment)
+
+      expect(policy.update?).to eq(true)
+    end
+
+    context "when the policy is overriden" do
+      it "returns the correct overriden policy for a Post record" do
+        post = Post.new(user)
+
+        policy = controller.policy(post)
+        expect(policy).to be_instance_of(PostPolicy)
+        expect(policy.user).to eq(user)
+        expect(policy.post).to eq(post)
+      end
+
+      it "returns the correct overriden policy for a Blog record" do
+        blog = Blog.new
+
+        policy = controller.policy(blog)
+        expect(policy).to be_instance_of(BlogPolicy)
+        expect(policy.user).to eq(user)
+        expect(policy.blog).to eq(blog)
+      end
+
+      it "raises an error if the given policy can't be found" do
+        record = Article.new
+
+        expect { controller.policy(record) }.to raise_error(Pundit::NotDefinedError)
+      end
+    end
   end
 
   describe "#policy_scope" do

spec/spec_helper.rb

@@ -183,6 +183,10 @@ def resolve
 
   module Admin
     class CommentPolicy < Struct.new(:user, :comment)
+      def self.policy_class
+        CommentPolicy
+      end
+
       def update?
         true
       end
@@ -191,6 +195,16 @@ def destroy?
         false
       end
     end
+
+    class Post < Post
+      def model_name
+        OpenStruct.new(param_key: "admin_post")
+      end
+
+      def self.policy_class
+        PostPolicy
+      end
+    end
   end
 end