Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

Fixing 'Example' replacements on the rename script #33

Open
wants to merge 1 commit into
base: 4.1
Choose a base branch
from

Conversation

csamir
Copy link

@csamir csamir commented Mar 14, 2016

Watched a VMOD talk in the Varnish Summit SF, apparently there was a small issue with the renaming script. This might help with it. I didn't test it thoroughly but it worked for me.

Before the change, after renaming 'example' to 'goodrexeg' :

$ grep -R -P '[Ee]xample' *
README.rst:Varnish Example Module
README.rst:Example Varnish vmod demonstrating how to write an out-of-tree Varnish vmod.
README.rst:Example
debian/control:Description: Example vmod for Varnish
src/vmod_goodregex.vcc:$Module goodregex 3 Example VMOD
vmod-goodregex.spec:Summary: Example VMOD for Varnish
vmod-goodregex.spec:Example VMOD
$

After the change :

$ grep -R -P '[Ee]xample' *
$

Feel free to close the Pull request if you have another solution, no feelings will be hurt but if it helps, glad it did!

Regards,
Samir

@dridi
Copy link
Member

dridi commented Mar 14, 2016

Hi @csamir,

I'm probably responsible for the issue during the SF summit. I fixed it in the master branch (42cdf17) but haven't backported the commit to version branches.

Can you please try the master branch and confirm the rename script works as expected?

Thanks,
Dridi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants