Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter3 - first draft #18

Merged
merged 20 commits into from
Jun 4, 2024
Merged

Chapter3 - first draft #18

merged 20 commits into from
Jun 4, 2024

Conversation

hcadavid
Copy link
Contributor

@hcadavid hcadavid commented May 13, 2024

Linked to issue #5

For this episode, I'm proposing a concrete collaboration scenario that (in addition to the defined objectives) helps connecting theory (from Episodes #1 and #2) with some hands-on practice. For this, I'm assuming that, before the workshop, the two collaborations mentioned on the challenges are already on the per-participant v6-server 'playground'.

I'm adding Djura also as a reviewer as we will work together on the 'CLI'-based complementary version of this episode.

Copy link

github-actions bot commented May 13, 2024

NOTE: This Pull Request (#18) was previously merged

github-actions bot pushed a commit that referenced this pull request May 13, 2024
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Vantage6 -> vantage6 except when the sentence starts with vantage6.
  • please expand v6 to vantage6
  • Study concept is not explained
  • In the text I would expect a basic explanation of the UI so the challenges make more sense.

episodes/chapter3.md Outdated Show resolved Hide resolved
episodes/chapter3.md Outdated Show resolved Hide resolved
episodes/chapter3.md Outdated Show resolved Hide resolved
episodes/chapter3.md Show resolved Hide resolved
episodes/chapter3.md Outdated Show resolved Hide resolved
episodes/chapter3.md Outdated Show resolved Hide resolved
episodes/chapter3.md Show resolved Hide resolved
episodes/chapter3.md Outdated Show resolved Hide resolved
episodes/chapter3.md Outdated Show resolved Hide resolved
episodes/chapter3.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request May 17, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@hcadavid
Copy link
Contributor Author

Thanks @frankcorneliusmartin for the detailed comments and feedback. I'm still working on some of them (the ones still with no response), and replied with follow-up questions on others (the remaining ones were already committed on the branch).

Regarding your general comments, what do you mean by a 'study concept'?

  • Study concept is not explained

github-actions bot pushed a commit that referenced this pull request Jun 3, 2024
hcadavid and others added 7 commits June 4, 2024 11:07
… one (as an introduction to the UI)

- The ER model as presented could be way too complex to be 'conceptualized' by the participants. I created a simplified version focused on what is key for this episode, including other key concepts that are important despite not being part of the v6 data model (algorithm and algorithm store)
- The steps were moved to the solution (with exception of the last challenge), and the questions where reworded to make the exercise more challenging as suggested.
@dsmits dsmits merged commit 96db608 into main Jun 4, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : 96db608
Branch  : main
Author  : Djura <[email protected]>
Time    : 2024-06-04 09:07:50 +0000
Message : Merge pull request #18 from vantage6/chapter3

Chapter3 - first draft
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : 54e7285
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 09:08:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 96db608
Branch  : main
Author  : Djura <[email protected]>
Time    : 2024-06-04 09:07:50 +0000
Message : Merge pull request #18 from vantage6/chapter3

Chapter3 - first draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Draft episode 3: Running PET analysis without programming
3 participants