Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved clarity of "Oh no a hacker!" exercise #133

Merged

Conversation

dsmits
Copy link
Member

@dsmits dsmits commented Sep 26, 2024

No description provided.

@dsmits dsmits linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 26, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/vantage6/vantage6-workshop/compare/md-outputs..md-outputs-PR-133

The following changes were observed in the rendered markdown documents:

 chap1_introduction_FL.md | 17 ++++++-----------
 md5sum.txt               |  2 +-
 2 files changed, 7 insertions(+), 12 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-08 11:08:45 +0000

@dsmits dsmits requested review from hcadavid and removed request for wbaccinelli September 26, 2024 11:59
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
Copy link
Member

@bartvanb bartvanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@hcadavid hcadavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hcadavid hcadavid merged commit 5c7ad50 into main Oct 8, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
Auto-generated via {sandpaper}
Source  : 5c7ad50
Branch  : main
Author  : Héctor Fabio Cadavid Rengifo <[email protected]>
Time    : 2024-10-08 11:09:24 +0000
Message : Merge pull request #133 from vantage6/131-change-request-add-second-question-to-oh-no-a-hacker

Improved clarity of "Oh no a hacker!" exercise
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
Auto-generated via {sandpaper}
Source  : 25f2ef0
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-08 11:10:11 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5c7ad50
Branch  : main
Author  : Héctor Fabio Cadavid Rengifo <[email protected]>
Time    : 2024-10-08 11:09:24 +0000
Message : Merge pull request #133 from vantage6/131-change-request-add-second-question-to-oh-no-a-hacker

Improved clarity of "Oh no a hacker!" exercise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Change Request] Add second question to Oh no! a hacker!
3 participants