refactor(site): unify components with export const arrow function, simplify structure in system and typography #1471
Conversation
sukvvon
commented
Aug 31, 2024
•
sukvvon
commented
- unify components with export const arrow function, add Props interface for each component,
- simplify structure in system and typography
….ts like system, unify with export arrow func style
…d Props interface for each component
|
sukvvon
changed the title
sukvvon
changed the title
| @@ -0,0 +1,2 @@ | |||
| export * from './reset.css'; | |||
There was a problem hiding this comment.
I'd honestly prefer not to have barrel files. They just cause indirection and don't serve much of a purpose in a relatively small app like this docs site.
| @@ -2,7 +2,11 @@ import { ReactNode } from 'react'; | |||
| import { Box } from '../system'; | |||
| import * as styles from './Blockquote.css'; | |||
|
|
|||
| export default (props: { children: ReactNode }) => { | |||
| export interface BlockquoteProps { | |||
There was a problem hiding this comment.
This export, and probably all the other exports you've added to prop types, are not necessary because those types aren't used outside the files they're defined in. They can be removed.
