Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack/next: Fix webpack template strings by using a modified regex from the webpack source #1333

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Feb 27, 2024

Fixes #1322.

The regex we made was giving false positives, resulting in escaped paths that didn't need escaping (e.g. [blog-id] does not need to be escaped). We're now using a modified version of the regex webpack uses so we only escape exactly what webpack matches.

Copy link

changeset-bot bot commented Feb 27, 2024

🦋 Changeset detected

Latest commit: 05dc53d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vanilla-extract/webpack-plugin Patch
@vanilla-extract/next-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis requested review from mrm007 and a team February 27, 2024 11:11
@askoufis askoufis changed the title Fix webpack template strings by using a modified regex from the webpack source webpack/next: Fix webpack template strings by using a modified regex from the webpack source Mar 8, 2024
@askoufis askoufis enabled auto-merge (squash) March 8, 2024 23:25
@askoufis askoufis merged commit 6ac9f66 into master Mar 8, 2024
11 checks passed
@askoufis askoufis deleted the fix-webpack-template-strings branch March 8, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Didn't get a result from child compiler error occurs when dynamic routes params like /blogs/[blog-id]
2 participants