-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Babel config to target modern browsers/Node.js #1262
Conversation
🦋 Changeset detectedLatest commit: 3a0049e The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hello, this change leads to anything using |
@mydea Sorry about that. We don’t rely on any new or deprecated Vite and vite-node APIs, which is why we treated this as a routine dependency bump. And, as you are probably aware, versions of Node.js <18 are end-of-life and no longer maintained. While we don’t have a defined Node.js support policy, following the Node.js release schedule would be a reasonable expectation. It looks like your integration tests run against Remix v1, so pinning Interestingly, Remix’s support policy states that they can drop support for EOL versions of Node.js in a minor version:
|
Fixes #1236
await import('vite')
syntaxPreviously, we were using the
esmodules
target which targets the very first versions of browsers that support ES Modules. That includes a lot of transforms that we don't need to run anymore. Related PR: #520How Babel targets changed after tweaking the Babel config:
Before
After