Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug id for custom identifiers #1229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ufaubion-oracle
Copy link

@ufaubion-oracle ufaubion-oracle commented Nov 13, 2023

PR created to resolve #1228

Details:
I changed integrations transformer code to only skip "@vanilla-extract/babel-plugin-debug-ids" when the identOption !== 'short'.

Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: 3d04b52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vanilla-extract/integration Minor
@vanilla-extract-private/tests Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis
Copy link
Contributor

As discussed in the discord thread linked in the issue, I don't think that the best solution is just enabling it for everything except short. This would force the debug ID babel transform on consumers that want a custom identifier, but don't want debug IDs (e.g. in production).

I think ideally the custom identifier function would be separate to the debug identifier option. There could be a bit of nuance here if we want to avoid a breaking change in every integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debugId missing for custom identifiers
2 participants