-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next-plugin): Next.js 13.5.x build not outputting css on windows #1193
fix(next-plugin): Next.js 13.5.x build not outputting css on windows #1193
Conversation
🦋 Changeset detectedLatest commit: 602b1d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think comments can be changed a bit // https://github.com/vercel/next.js/blob/5b52e7772dd6237474931ba4bbb856fbc33142ad/packages/next/src/build/index.ts#L431
// https://github.com/vercel/next.js/blob/5b52e7772dd6237474931ba4bbb856fbc33142ad/packages/next/src/build/webpack-config.ts#L493
// https://github.com/vercel/next.js/pull/43916
// on Next.js 12, findPagesDirResult is a string. on Next.js 13, findPagesDirResult is an object
const findPagesDirResult = findPagesDir(
dir,
resolvedNextConfig.experimental?.appDir ?? false,
);
// Skip nextConfig check since appDir is stable feature after Next.js 13.4
const hasAppDir = !!(findPagesDirResult && findPagesDirResult.appDir); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Feel free to add the comments suggested in #1193 (comment), but they shouldn't block the PR.
CSS output is not working again in Next.js 13.5.x and Windows.
The
resolvedNextConfig.experimental.appDir
is no longer available in Next.js 13.5.x, so this pre-condition has been removed.References: https://github.com/vercel/next.js/blob/76e06d55a8c42090dafda25ec31d9eeaa7ec647c/packages/next/src/build/index.ts#L418-L422