Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pnpm to v8, node to v20 #1185

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Bump pnpm to v8, node to v20 #1185

merged 6 commits into from
Nov 9, 2023

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Sep 16, 2023

Doing a bit of spring cleaning 🧹. Up first is pnpm and node. Nothing of note for node, but the new pnpm major came with a new lockfile format.

NOTE: Not dropping support for any specific version of node in this PR. We don't even officially have a supported version anyway (AFAIK), but I think it's safe to drop testing on 14 given it became EOL ~4 months ago. 16 just became EOL a few days ago, but happy to keep it around for now.

This might also require a tweak to the branch protection since it's expecting a node 14 CI step to pass but it's now named node 16.

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023

⚠️ No Changeset found

Latest commit: 187d498

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@askoufis askoufis changed the title Bump pnpm to v8, node to 18 Bump pnpm to v8, node to v18 Sep 16, 2023
@askoufis askoufis requested a review from a team October 24, 2023 22:09
@mrm007 mrm007 changed the title Bump pnpm to v8, node to v18 Bump pnpm to v8, node to v20 Nov 8, 2023
"pnpm": {
"patchedDependencies": {
"[email protected]": "patches/[email protected]"
}
},
"volta": {
"node": "20.9.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the pnpm volta config, or does this cause an error if you don't enable have the volta envar set?

Copy link
Contributor

@mrm007 mrm007 Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, however it's prone to be forgotten (as was the case with this PR). Upgrading pnpm means you need to change packageManager, as well as the volta.pnpm key.

packageManager is more of a de facto standard, which is why I added it.

@mattcompiles mattcompiles enabled auto-merge (squash) November 8, 2023 11:48
@mattcompiles mattcompiles disabled auto-merge November 8, 2023 11:48
@mattcompiles mattcompiles merged commit 7961d16 into master Nov 9, 2023
11 checks passed
@mattcompiles mattcompiles deleted the pnpm-node-bump branch November 9, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants