Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added example for Nuxt3 #1140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hecatron
Copy link

I've added an example for Nuxt 3
If this goes through I might also be tempted to add some more for other frameworks as well, such as svelte etc.

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: bebd18f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +12 to +15
// Note currently server side rendering seems to break hmr (hot module reloading) with Nuxt
// One workaround is to instead bundle the vue components into a seperate vite built library
// Or disable SSR while developing components
ssr: false,
Copy link
Collaborator

@graup graup Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about linking to the issue https://github.com/vanilla-extract-css/vanilla-extract/issues/1118


export const externalStyle = style({
color: 'red'
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as barebones as it gets. How do you feel about showing at least a few more of the basic features, like themes, vars, variants and maybe dynamic variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants