Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate textchangetrackingtests.xml by xsl script #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kossebau
Copy link
Contributor

  • allows better maintainance of all duplicated content
  • adds a test variant for changes in style:footer-left

Pretty complex xsl, any ideas how to cut that down? First approach with embedded logic failed due to xsl:call-template only taking hardcoded name attributes, nothing that can be evaluated.
So turned to more declarative description of test structure variants.

* allows better maintainance of all duplicated content
* adds a test variant for changes in style:footer-left
@vandenoever
Copy link
Owner

Could you explain a bit what you changed? The diff is not immediately clear and quite big due to code movements.

@kossebau
Copy link
Contributor Author

Could you explain a bit what you changed? The diff is not immediately clear and quite big due to code movements.

Before textchangetrackingtests.xml was manually written, containing lots of duplicated stuff. The change is that textchangetrackingtests.xml is now generated from the new xsl script tests/createTextChangeTrackingTests.xsl.

The output of that script should be pretty the same, as before, besides indentation and the xml:id values used. And there are three new tests *_style_footer_left. Those are the third variant of the existing 3 types, adding to *_office_text and *_style_footer. Which makes 9 tests now. More to come (header ones :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants