Middleware to decode encoding and charset #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteymix
force-pushed
the
decode-middlewares
branch
2 times, most recently
from
b7338bd to
d0d1b04
Compare
arteymix
force-pushed
the
decode-middlewares
branch
2 times, most recently
from
f539fce to
6a22513
Compare
arteymix
force-pushed
the
decode-middlewares
branch
4 times, most recently
from
2c4834c to
32fcd73
Compare
The 'decode' middleware unapply various codings specified in 'Content-Encoding' headers. It's also possible to forward remaining encodings instead of simply raising a '501 Not Implemented'. Provide tests and documentation.
arteymix
force-pushed
the
decode-middlewares
branch
from
32fcd73 to
0429bc6
Compare
| for (unowned SList<string> encoding = encodings; encoding != null; encoding = encoding.next) { | ||
| switch (encoding.data.down ()) { | ||
| case "gzip": | ||
| case "x-gzip": |
There was a problem hiding this comment.
It would be nice to peek the gzip header and figure out the size if it's available.
|
Looks good to me. Two things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two really useful middlewares to decode applied encoding and content charset.
content-codingmeta data for plugins quixdb/squash#197)deflatebug on IE (see https://en.wikipedia.org/wiki/HTTP_compression)It will require some documentation and tests. The logic is quite tricky, especially for
decodeas remaining encodings are reversed back in the headers.I couldn't find anything more appropriate than
501 Not Implementedto indicate the lack of support for an encoding or charset.The typical use case is on the top of an app or for an upload processing:
The squash integration must be opt-in with fallback on the basic converters.