Fix RPC timeouts #76
Merged
Fix RPC timeouts #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only search up to a specific number of days in the past (`redeem_margin_days`) for redeeming positions. This is done to avoid a known timeout limitation of getblock's Gnosis RPCs. Positions for older markets will have to be manually redeemed.
Adamantios
commented
Sep 7, 2023
Comment on lines
+94
to
+95
| "If the issue persists, try to decrease the value of `redeem_margin_days` " | ||
| f"in the agent's configuration, based on the date corresponding to the block number {earliest_block}." |
There was a problem hiding this comment.
Advice to the user in case a timeout occurs.
Adamantios
commented
Sep 7, 2023
Comment on lines
63
to
65
| answerFinalizedTimestamp_not: null, | ||
| creationTimestamp_gt: "${from_timestamp}", | ||
| isPendingArbitration: false |
There was a problem hiding this comment.
We only get trades from_timestamp old.
Adamantios
commented
Sep 7, 2023
Comment on lines
-187
to
+192
| query = trades.substitute(creator=safe.lower()) | ||
| redeem_margin = self.params.redeem_margin_days * DAY_UNIX | ||
| from_timestamp = self.synced_time - redeem_margin | ||
| query = trades.substitute(creator=safe.lower(), from_timestamp=from_timestamp) |
There was a problem hiding this comment.
from_timestamp is calculated using the synced time minus a configurable margin given in days.
0xArdi
reviewed
Sep 7, 2023
| query = trades.substitute(creator=safe.lower()) | ||
| redeem_margin = self.params.redeem_margin_days * DAY_UNIX | ||
| from_timestamp = self.synced_time - redeem_margin | ||
| query = trades.substitute(creator=safe.lower(), from_timestamp=from_timestamp) |
There was a problem hiding this comment.
I assume the event filter later on is made s.t. the lowest block is used from this response, correct?
I am asking because I don't see changes related to from_block, or something like that.
Adamantios
commented
Sep 7, 2023
Comment on lines
+90
to
+108
| value_enforcement = ( | ||
| f"The value needs to be in the exclusive range (0, {GNOSIS_RPC_TIMEOUT_DAYS}) " | ||
| f"and manual redeeming has to be performed for markets older than {GNOSIS_RPC_TIMEOUT_DAYS - 1} days." | ||
| ) | ||
|
|
||
| if redeem_margin_days <= 0: | ||
| raise ValueError( | ||
| "The margin in days for the redeeming information (`redeem_margin_days`) " | ||
| f"cannot be set to {redeem_margin_days} <= 0. {value_enforcement}" | ||
| ) | ||
| if redeem_margin_days >= GNOSIS_RPC_TIMEOUT_DAYS: | ||
| raise ValueError( | ||
| "Due to a constraint of the Gnosis RPCs, it is not possible to configure the redeeming " | ||
| f"information's time window to exceed {GNOSIS_RPC_TIMEOUT_DAYS - 1} days " | ||
| f"(currently {redeem_margin_days=}). To clarify, these RPCs experience timeouts " | ||
| "when attempting to filter for historical on-chain events. " | ||
| "Practical testing of the service has revealed that timeouts consistently occur for blocks " | ||
| f"approximately {GNOSIS_RPC_TIMEOUT_DAYS} days old. {value_enforcement}" | ||
| ) |
There was a problem hiding this comment.
Do not allow the margin to be less than 1 or more than GNOSIS_RPC_TIMEOUT_DAYS - 1 (currently 24).
0xArdi
approved these changes
Sep 7, 2023
Adamantios
force-pushed
the
fix/rpc-timeout
branch
from
b8ae78e to
c31c940
Compare
angrybayblade
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a known timeout limitation of getblock's Gnosis RPCs.
The service now only searches up to a specific number of days in the past (
redeem_margin_days) for redeeming positions. Positions for older markets will have to be manually redeemed.