Fix formatting error and problematic property and increase the chances of meeting the KPIs #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
annasambrook
commented
Dec 2, 2024
•
annasambrook
commented
- Fixes a formatting error from the health check endpoint PR.
- Removes problematic getter and setter in e58c899.
- Increases the chances of meeting the KPIs in 35acd55.
- The getter and setter use an attribute that is missing from the init. - The getter and setter have the same name as an already existing attribute in the init and this can cause issues: https://github.com/valory-xyz/trader/blob/6d1a7f53c9aec6df359a603d3df700de3ef68ded/packages/valory/skills/decision_maker_abci/models.py#L228
Adamantios
force-pushed
the
fix/formatting-error
branch
from
987bd08 to
ca3c5b3
Compare
Adamantios
changed the title
Removed in order to increase the chances of meeting the KPIs.
Adamantios
force-pushed
the
fix/formatting-error
branch
from
ca3c5b3 to
882d36e
Compare
Adamantios
changed the title
Adamantios
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.