Fix issues introduced by the benchmarking mode changes #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally removed in 9f772a3.
The synchronized data are utilized in the overridden `end_block` method. Properties of the decision maker abci's synchronized data need to be accessed.
Adamantios
force-pushed
the
fix/benchmarking
branch
from
58be324 to
fb02164
Compare
Adamantios
commented
Nov 29, 2024
Comment on lines
-154
to
+155
| benchmarking_finished = False | ||
| day_increased = False | ||
| benchmarking_finished = None | ||
| day_increased = None |
There was a problem hiding this comment.
This was causing an issue in the normal flow.
There was a problem hiding this comment.
Still trying to understand why None is a valid value and False not.
There was a problem hiding this comment.
Because otherwise the NONE event cannot ever be emitted from the round.
| @@ -218,6 +219,7 @@ class DecisionMakerAbciApp(AbciApp[Event]): | |||
| Event.DONE: SubscriptionRound, | |||
| Event.NONE: FinishedWithoutDecisionRound, | |||
| Event.NO_MAJORITY: SamplingRound, | |||
| Event.ROUND_TIMEOUT: SamplingRound, | |||
There was a problem hiding this comment.
This was causing an issue in the normal flow.
| @@ -48,6 +48,7 @@ class SamplingRound(UpdateBetsRound): | |||
| get_name(SynchronizedData.benchmarking_finished), | |||
| get_name(SynchronizedData.simulated_day), | |||
| ) | |||
| synchronized_data_class = SynchronizedData | |||
There was a problem hiding this comment.
This was causing an issue in the normal flow.
There was a problem hiding this comment.
still sampling is connected with two different SynchronizedData classes in two different abcis
There was a problem hiding this comment.
Can you elaborate on that?
keshav1998
approved these changes
Nov 29, 2024
cyberosa
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues introduced in #347 and replaces #362.