Hotfix/staking kpi reachability #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bets class objects will now also tracking the amount being invested.
invested amount during update should be added instead of updating the new value
the new variable name signifies that it is an internal calculated value
The sampling logic follows the specified priority logic:
1. Filter out all the bets that have a processed_timestamp != 0 to get a list of new bets.
2. If the list of new bets is not empty:
2.1 Order the list in decreasing order of liquidity (highest liquidity first).
2.2 For bets with the same liquidity, order them in decreasing order of market closing time (openingTimestamp).
3. If the list of new bets is empty:
3.1 Order the bets in decreasing order of invested_amount.
3.2 For bets with the same invested_amount, order them in increasing order of processed_timestamp (least recently processed first).
3.3 For bets with the same invested_amount and processed_timestamp, order them in decreasing order of liquidity.
3.4 For bets with the same invested_amount, processed_timestamp, and liquidity, order them in decreasing order of market closing time (openingTimestamp).
Updates the investment amount and transaction timestamp if reedeem round is reached from post_tx_round
packages/valory/skills/decision_maker_abci/behaviours/sampling.py
Outdated
Show resolved
Hide resolved
annasambrook
previously approved these changes
Nov 22, 2024
Co-authored-by: Anna Sambrook <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
… into hotfix/staking-kpi-reachability
… exhausted." This reverts commit 8d3b9af.
Adamantios
previously approved these changes
Dec 6, 2024
Adamantios
previously approved these changes
Dec 9, 2024
annasambrook
reviewed
Dec 9, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Otherwise, the `tx_submitter` will not be available in the db for the current period, and either way it would not make sense to update the transaction information for a past period's decision.
Adamantios
dismissed stale reviews from annasambrook and themself
via
e0a0fad
annasambrook
previously approved these changes
Dec 9, 2024
Adamantios
previously approved these changes
Dec 9, 2024
Previously, we were only aware of a new epoch if our own agent was the one to call the checkpoint. If any other agent had called it, then we would never be aware of this event. Instead, we are now tracking changes to the ts checkpoint of the contract which only and always gets updated after a new epoch is triggered.
Adamantios
dismissed stale reviews from annasambrook and themself
via
de664a8
Adamantios
force-pushed
the
hotfix/staking-kpi-reachability
branch
from
de664a8 to
48d1f1e
Compare
Adamantios
force-pushed
the
hotfix/staking-kpi-reachability
branch
from
48d1f1e to
b8190fc
Compare
Adamantios
approved these changes
Dec 11, 2024
annasambrook
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.