Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pearl trader #356

Open
wants to merge 2 commits into
base: chore/reorg
Choose a base branch
from

Conversation

jmoreira-valory
Copy link
Collaborator

@jmoreira-valory jmoreira-valory commented Nov 20, 2024

Update Pearl trader for the refactored branch on olas-operate.

⚠️ Important: This update is for the current trader_pearl used in olas-operate #344, which is referenced here: https://github.com/valory-xyz/olas-operate-app/blob/da917f717745a09f4548d0d239f4e4e6e8394748/frontend/constants/serviceTemplates.ts#L7 and introduces the changes required for the refactored branch valory-xyz/olas-operate-app#428, which mainly concerns the introduction of environment variables.

@OjusWiZard
Copy link
Member

diff from bafybeidicxsruh3r4a2xarawzan6ocwyvpn3ofv42po5kxf7x6ck7kn22u to this trader_pear/service.yaml is this: https://www.diffchecker.com/HY2yJFMe/

@jmoreira-valory
Copy link
Collaborator Author

jmoreira-valory commented Nov 20, 2024

@Adamantios confirm that the trader_pearl configuration in this PR is appropriate for 0.18.2 / 0.18.7

@Adamantios
Copy link
Collaborator

@Adamantios confirm that the trader_pearl configuration in this PR is appropriate for 0.18.2 / 0.18.7

The configs look good from a framework's perspective. Could you elaborate on that more?

@jmoreira-valory
Copy link
Collaborator Author

The comment is about if you could check if the pearl_trader.yaml is missing (or has an inconvenient value) for any config params that have been introduced recently, in terms of of tools/multibets/simulation/... etc.

@Adamantios
Copy link
Collaborator

The comment is about if you could check if the pearl_trader.yaml is missing (or has an inconvenient value) for any config params that have been introduced recently, in terms of of tools/multibets/simulation/... etc.

You could diff with the main service config and use the exact same defaults. I think we could merge the two service files anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants