Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for market_manager #314

Merged
merged 15 commits into from
Sep 6, 2024

Conversation

Ravleen-Solulab
Copy link
Contributor

This PR contains test scripts for market_manager_abci.

@Ravleen-Solulab Ravleen-Solulab force-pushed the Test-for-market_manager branch from 2845d2a to ed32b88 Compare August 22, 2024 11:22
Copy link
Collaborator

@Adamantios Adamantios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the hashes and cover the following:

Name                                                                                     Stmts   Miss  Cover   Missing
--------------------------------------------------------------------------------------------------------------------------------------------------------

packages/valory/skills/market_manager_abci/rounds.py                                        44      4    91%   57-58, 68, 85

Moreover, please add the market_manager_abci and the check_stop_trading_abci (which tests were merged just now from #319) here:

trader/tox.ini

Lines 102 to 105 in b04a826

[commands-packages]
commands =
{[commands-base]commands}
pytest -rfE {env:SKILLS_PATHS}/decision_maker_abci/tests --cov={env:SKILLS_PATHS}/decision_maker_abci --cov-report=xml --cov-report=term --cov-report=term-missing --cov-config=.coveragerc {posargs}

@Ravleen-Solulab
Copy link
Contributor Author

Could you please tell me specifically what did I miss?

@Adamantios
Copy link
Collaborator

Could you please tell me specifically what did I miss?

Lines 57-58, 68, 85 are not covered in rounds.

tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@Adamantios Adamantios merged commit 48fe86c into valory-xyz:main Sep 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants