-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test for market_manager #314
test for market_manager #314
Conversation
2845d2a
to
ed32b88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the hashes and cover the following:
Name Stmts Miss Cover Missing
--------------------------------------------------------------------------------------------------------------------------------------------------------
packages/valory/skills/market_manager_abci/rounds.py 44 4 91% 57-58, 68, 85
Moreover, please add the market_manager_abci
and the check_stop_trading_abci
(which tests were merged just now from #319) here:
Lines 102 to 105 in b04a826
[commands-packages] | |
commands = | |
{[commands-base]commands} | |
pytest -rfE {env:SKILLS_PATHS}/decision_maker_abci/tests --cov={env:SKILLS_PATHS}/decision_maker_abci --cov-report=xml --cov-report=term --cov-report=term-missing --cov-config=.coveragerc {posargs} |
Could you please tell me specifically what did I miss? |
Lines 57-58, 68, 85 are not covered in rounds. |
71c35f4
to
ba744bd
Compare
This PR contains test scripts for market_manager_abci.